From e4c0d3679f13bb6a6244612546111fbd24388dbf Mon Sep 17 00:00:00 2001 From: Keir Fraser Date: Mon, 31 Aug 2009 09:51:45 +0100 Subject: [PATCH] x86, ept: remove execute permission for granted pages' P2M entries When backporting c/s 20026 I noticed that granted pages get execute permission, which doesn't seem desirable (and has been avoided for PV guests for quite a while). Even for p2m_mmio_direct is seems suspicious to allow execution, but me being less certain here I left it as is for the time being. Signed-off-by: Jan Beulich --- xen/arch/x86/mm/hap/p2m-ept.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/mm/hap/p2m-ept.c b/xen/arch/x86/mm/hap/p2m-ept.c index 91a8b40911..1aa0a6ff37 100644 --- a/xen/arch/x86/mm/hap/p2m-ept.c +++ b/xen/arch/x86/mm/hap/p2m-ept.c @@ -40,15 +40,21 @@ static void ept_p2m_type_to_flags(ept_entry_t *entry, p2m_type_t type) return; case p2m_ram_rw: case p2m_mmio_direct: - case p2m_grant_map_rw: entry->r = entry->w = entry->x = 1; return; case p2m_ram_logdirty: case p2m_ram_ro: - case p2m_grant_map_ro: entry->r = entry->x = 1; entry->w = 0; return; + case p2m_grant_map_rw: + entry->r = entry->w = 1; + entry->x = 0; + return; + case p2m_grant_map_ro: + entry->r = 1; + entry->w = entry->x = 0; + return; } } -- 2.30.2